fix: correct PHPUnit mock setups in tests#1264
Merged
garak merged 2 commits intophpunit-upgradefrom Mar 2, 2026
Merged
Conversation
Merged
Co-authored-by: garak <179866+garak@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Upgrade PHPUnit and modernize test suite
fix: correct PHPUnit mock setups and modernize test assertions
Feb 28, 2026
Member
|
@copilot there's no change on phpunit version here: composer.json is still the same, and phpunit.xml.dist also. |
Contributor
Author
Correct —
The PR description I wrote was misleading; I was describing the full scope of the stacked PR, not just my additions. |
Copilot
AI
changed the title
fix: correct PHPUnit mock setups and modernize test assertions
fix: correct PHPUnit mock setups in tests
Mar 2, 2026
There was a problem hiding this comment.
Pull request overview
Updates the PHPUnit test suite to align mock expectations with how the use case classes actually interact with App\Badge\Model\Package after the PHPUnit upgrade, eliminating failures caused by mocking the wrong delegation path.
Changes:
- Fixes
CreateComposerLockBadgeTestandCreateCircleCiBadgeTestto mockPackage::getRepository()directly (instead of expectinggetOriginalObject()to be invoked). - Updates
SnippetGeneratorTest’s routergenerate()callback signature to accept the 3rd argument used bySnippetGenerator::generateImg(). - Makes the router mock in
SnippetGeneratorTestfail fast on unexpected route names to avoid silently masking regressions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Service/SnippetGeneratorTest.php | Aligns router mock callback signature with production calls and makes unexpected route names explicit failures. |
| tests/Badge/Model/UseCase/CreateComposerLockBadgeTest.php | Corrects mock setup to match direct getRepository() usage in the use case. |
| tests/Badge/Model/UseCase/CreateCircleCiBadgeTest.php | Corrects mock setup to match direct getRepository() usage and ensures error-path test triggers the intended catch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
garak
added a commit
that referenced
this pull request
Mar 3, 2026
fix: correct PHPUnit mock setups in tests
garak
added a commit
that referenced
this pull request
Mar 3, 2026
fix: correct PHPUnit mock setups in tests
garak
added a commit
that referenced
this pull request
Mar 3, 2026
fix: correct PHPUnit mock setups in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failures caused by incorrect mock setups in the test suite.
Improvement
Summary
Fixes 4 errors and 1 failure in the PHPUnit test suite that were caused by incorrect mock setups. The
composer.jsonandphpunit.xml.distchanges (PHPUnit ^12.4, Symfony 7.3,BypassFinalExtension) are in the basephpunit-upgradebranch; this PR only fixes the resulting test failures.Root cause: Several tests mocked
Package::getOriginalObject()expecting it to be called, but the use case classes call$package->getRepository()directly on the mock. PHPUnit mocks replace all methods, so the real delegation chain is never invoked.Test fixes
CreateCircleCiBadgeTest::testShouldCreateDefaultBadgeOnError— removed$repointermediate mock andgetOriginalObjectexpectation; throwRuntimeExceptionfromgetRepository()to triggercatch (\Throwable)CreateComposerLockBadgeTest::testShouldCreateComposerLockBadge— mockgetRepository()directly instead of routing throughgetOriginalObject()CreateComposerLockBadgeTest::testShouldCreateDefaultBadgeOnError— same pattern;catch (\Exception)catches theRuntimeExceptionfromgetRepository()SnippetGeneratorTest improvements
int $referenceType = RouterInterface::ABSOLUTE_URLto the router mock callback to match the 3-argument signature used bySnippetGenerator::generateImg()?? 'repo_url'fallback with an explicit\InvalidArgumentExceptionfor unexpected route names, preventing regressions from masking unknown routes🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.